Skip to content

Don't report unused diagnostics when the unused node has a parse error #25598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
Jul 13, 2018
Merged

Don't report unused diagnostics when the unused node has a parse error #25598

2 commits merged into from
Jul 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 12, 2018

Fixes #25591

@ghost ghost requested review from DanielRosenwasser, mhegazy and amcasey July 12, 2018 01:25
@ghost ghost force-pushed the noSuggestionDiagnosticsOnParseError branch from 3f62a5c to 23d0bae Compare July 12, 2018 01:27
@ghost ghost force-pushed the noSuggestionDiagnosticsOnParseError branch from 23d0bae to e26e448 Compare July 12, 2018 01:56
amcasey
amcasey approved these changes Jul 12, 2018
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, assuming Matt confirms it doesn't cause flicker.

@ghost ghost changed the title Don't report suggestion diagnostics when a parse error exists Don't report unused diagnostics when the unused node has a parse error Jul 12, 2018
@ghost
Copy link
Author

ghost commented Jul 12, 2018

Waiting for @mjbvz to verify

@mjbvz
Copy link
Contributor

mjbvz commented Jul 12, 2018

@Andy-MS I'm still see the diagnostics when using the TS version from this PR, at least for the cases in #25591

@ghost
Copy link
Author

ghost commented Jul 13, 2018

Here's what it looks like to me:

typescript@next:
next

jake local on the noSuggestionDiagnosticsOnParseError branch:
branch

@mjbvz
Copy link
Contributor

mjbvz commented Jul 13, 2018

@Andy-MS You're right. I ran the wrong build command. Seems to be working well. I haven't notice any flickering or other odd behavior in my testing

@ghost ghost merged commit 1fb050b into master Jul 13, 2018
@ghost ghost deleted the noSuggestionDiagnosticsOnParseError branch July 13, 2018 00:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjbvz @mhegazy @amcasey