Revert "Emit, even in the presence of declaration errors and noEmitOnError #2470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Error." This reverts commit 19517ac.
CyrusNajmabadi
changed the title
|
👍 thanks! |
CyrusNajmabadi
added a commit
that referenced
this pull request
Mar 24, 2015
Revert "Emit, even in the presence of declaration errors and noEmitOnError
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 19517ac.
The impact of this change is that we will now no longer emit in the presence of declaration errors, if the user has noEmitOnError set to true.
Performance-wise, this seems to add about 1% to the overall compile time (i tested using the compiler). This seems like a reasonable cost in order to implement the noEmitOnError feature correctly.