Fix issue #22923: more sofisticated #23058
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhomchenko
force-pushed
the
fix/22923-option-2
branch
from
a8ad91f to
5d2055b
Compare
|
I think you should merge #23050 and this one in just one PR. |
mhegazy
reviewed
Apr 2, 2018
| @@ -16420,6 +16426,14 @@ namespace ts { | |||
| return suggestion && symbolName(suggestion); | |||
| } | |||
|
|
|||
| function typeHavingProperty(type: Type, property: __String, errorNode?: Node): Type | undefined { | |||
| const types: Type[] = (type.flags & TypeFlags.UnionOrIntersection) | |||
There was a problem hiding this comment.
i do not think you want to look in unions or intersections. if the promised type has the property then show the message.. not if one of the constituents of the union type has it.. since await will not fix this problem.
Merged
|
Closed in favor of #23050 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22923 but error message is more detailed.
Is an extension of #23050
I'm not sure which one will be ok.