Report JSDoc errors as semantic errors in checkJS mode #20106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows reporting of semantic errors as well. Semantic errors are likely to outnumber syntactic errors, so it's valuable not to block semantic errors on a few syntactic errors.
Add almost 37,000 semantic errors in addition to the 250 syntactic errors
mhegazy
reviewed
Nov 17, 2017
src/compiler/program.ts
Outdated
|
|
||
| const diagnostics = bindDiagnostics.concat(checkDiagnostics, fileProcessingDiagnosticsInFile, programDiagnosticsInFile); | ||
| let diagnostics = bindDiagnostics.concat(checkDiagnostics, fileProcessingDiagnosticsInFile, programDiagnosticsInFile); | ||
| if (isCheckJsEnabledForFile(sourceFile, options)) { |
There was a problem hiding this comment.
we already checked this a few lines above, maybe we should just do this once.
mhegazy
approved these changes
Nov 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19999
This allows reporting of semantic errors as well. Semantic errors are likely to outnumber syntactic errors, so it's valuable not to block semantic errors on a few syntactic errors.