Skip to content

Fix #18071: Printer failure when encountering RegularExpressionLiteral #18077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2017
Merged

Fix #18071: Printer failure when encountering RegularExpressionLiteral #18077

merged 2 commits into from
Aug 28, 2017

Conversation

fwouts
Copy link

@fwouts fwouts commented Aug 28, 2017

Fixes #18071

@msftclas
Copy link

@fwouts,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

rbuckton
rbuckton approved these changes Aug 28, 2017
View reviewed changes
Copy link
Contributor

@rbuckton rbuckton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, you can avoid this by passing true for the setParentNodes argument of createSourceFile, but this seems like a good change in any case.

@DanielRosenwasser DanielRosenwasser merged commit a60b103 into microsoft:master Aug 28, 2017
@DanielRosenwasser
Copy link
Member

Thanks!

@fwouts fwouts deleted the regex-bug branch August 28, 2017 21:14
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rbuckton rbuckton rbuckton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fwouts @msftclas @DanielRosenwasser @rbuckton