added extra check to prevent multiple installation of the same typing, added version field to telemetry event #12258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, added version field to telemetry event
mhegazy
approved these changes
Nov 15, 2016
mhegazy
reviewed
Nov 15, 2016
| @@ -5,6 +5,8 @@ | |||
| /// <reference path="../shared.ts"/> | |||
|
|
|||
| namespace ts.server.typingsInstaller { | |||
| const typingsInstallerVersion = "2.0.9"; | |||
There was a problem hiding this comment.
can we move the ts.version to core and use it here as well?
mhegazy
approved these changes
Nov 15, 2016
vladima
added a commit
that referenced
this pull request
Nov 15, 2016
…, added version field to telemetry event (#12258) * added extra check to prevent multiple installation of the same typing, added version field to telemetry event * use ts.version
vladima
added a commit
that referenced
this pull request
Nov 15, 2016
* treat failures to resolve module name as missing packages (#12237) * added extra check to prevent multiple installation of the same typing, added version field to telemetry event (#12258) * added extra check to prevent multiple installation of the same typing, added version field to telemetry event * use ts.version * switch to execSync to ensure that no install orders are interleaved (#12259) * Make sure version is public * Update file with version string for nightly release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressed comments left as a feedback for #12237
// CC @mhegazy