Salsa: bogus intelli-sense proposal

[egamma]

From @isidorn on January 26, 2016 16:20

• Have the following code:

Person.prototype.getName5 = function getName() {
  return this.name;
};

Person.getNa

• Trigger intelli-sense on the last line, last column, getNa*
• The first two proposals are bogus and should not appear.

Copied from original issue: microsoft/vscode#2386

[egamma]

From @mousetraps on January 26, 2016 17:28

Yeah, getNa should not appear in the completions list because it's redundant, but the appearance of getName is actually intentional because JavaScript is a dynamically typed language, and we're not going to always get things right, so we want to provide a gracefully degrading experience (listing all the identifiers) rather than trying to be smart and showing nothing at all. This way, at the very least, it acts as code-completion of you already know what you want to type. The problem here, then, is they these identifiers should be better sorted by confidence (getName5, then getName), not alphabetically.

In VS, in addition to sorting by confidence, we've considered demarcating the the lower confidence results w/ various styling attributes (eg removing the icon, changing the color) but I don't think we ended up landing on anything just yet.

Cc @bowdenk7

[egamma]

The proposal getNa is not helpful and it should not be proposed, even when it is an identifier at this point.

We have changed the icons in the proposal to distinguish inferred and proposal better.

Moving to Salsa

[RyanCavanaugh]

I don't think this is worth fixing. It would require the completion list code to keep track of what the user typed vs what was there before, and the existence of "the thing you're typing" shouldn't be confusing to anyone.

[mhegazy]

Chatted with @RyanCavanaugh offline, and this seems annoying enough for users that we should fix it.

[egamma]

👍