Skip to content

JSDoc comment templates/scaffolding may not use formatter newlines #52348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanielRosenwasser opened this issue Jan 21, 2023 · 1 comment · Fixed by #52349
Closed

JSDoc comment templates/scaffolding may not use formatter newlines #52348

DanielRosenwasser opened this issue Jan 21, 2023 · 1 comment · Fixed by #52349
Labels
Domain: Formatter The issue relates to the built-in formatter Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Milestone
Backlog

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jan 21, 2023 •
edited
Loading

Not that you should fix it in this PR, but it seems like a bug that we don't have this for JSDoc comments.

Originally posted by @jakebailey in #52298 (comment)

        return JsDoc.getDocCommentTemplateAtPosition(getNewLineOrDefaultFromHost(host, /*formatSettings*/ undefined), syntaxTreeCache.getCurrentSourceFile(fileName), position, options);
@DanielRosenwasser DanielRosenwasser added Help Wanted You can do this Good First Issue Well scoped, documented and has the green light Domain: Formatter The issue relates to the built-in formatter labels Jan 21, 2023
@jakebailey
Copy link
Member

To clarify out of context, "this" is formatSettings. I think this is just a plumbing problem.

@jakebailey jakebailey mentioned this issue Jan 21, 2023
Merged
@jakebailey jakebailey added this to the Backlog milestone Jan 23, 2023
jakebailey added a commit that referenced this issue Jan 23, 2023
@jakebailey
Plumb formatting to getDocCommentTemplateAtPosition (#52349)
1094188 
Fixes #52348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: Formatter The issue relates to the built-in formatter Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Plumb formatting to getDocCommentTemplateAtPosition jakebailey/TypeScript
2 participants
@DanielRosenwasser @jakebailey