getEditsForFileRename taking long time

[mjbvz]

TypeScript Version: 3.4.0-rc

Search Terms:

• getEditsForFileRename
• file move
• update imports

Repo

1. In the VS Code codebase
2. Open the file src/vs/editor/contrib/codeAction/codeAction.ts
3. Wait for js/ts language features to be fully initialized
4. Now rename this file to codeActionRenamed

Bug
This triggers a getEditsForFileRename request that takes between 5 and 10 seconds to resolve. Here's the tsserver.log.

[sheetalkamat]

@mjbvz I don't seem to see this either with vscode or insiders build from latest typescript build from master.
With vscode:

Info 8843 [15:43:2.305] request:
    {"seq":25,"type":"request","command":"getEditsForFileRename","arguments":{"file":"c:/github/vscode/src/vs/editor/contrib/codeAction/codeActionRename.ts","oldFilePath":"c:/github/vscode/src/vs/editor/contrib/codeAction/codeAction.ts","newFilePath":"c:/github/vscode/src/vs/editor/contrib/codeAction/codeActionRename.ts"}}
Perf 8844 [15:43:2.673] 25::getEditsForFileRename: elapsed time (in milliseconds) 367.1587

With insiders:

Info 8851 [15:46:54.377] request:
    {"seq":30,"type":"request","command":"getEditsForFileRename","arguments":{"oldFilePath":"c:/github/vscode/src/vs/editor/contrib/codeAction/codeAction.ts","newFilePath":"c:/github/vscode/src/vs/editor/contrib/codeAction/codeActionRenamed.ts"}}
Perf 8852 [15:46:54.706] 30::getEditsForFileRename: elapsed time (in milliseconds) 329.2082

[mjbvz]

I still see this using TS 3.4.1 but I think the long running request is actually the configure request we send before requesting getEditsForFileRename. Here's the VS Code timing of that request before getEditsForFileRename:

[Trace  - 10:53:31 AM] Sending request: configure (42). Response expected: yes. Current queue length: 3
Arguments: {
    "formatOptions": {
        "tabSize": 4,
        "indentSize": 4,
        "convertTabsToSpaces": false,
        "newLineCharacter": "\n",
        "insertSpaceAfterCommaDelimiter": true,
        "insertSpaceAfterConstructor": false,
        "insertSpaceAfterSemicolonInForStatements": true,
        "insertSpaceBeforeAndAfterBinaryOperators": true,
        "insertSpaceAfterKeywordsInControlFlowStatements": true,
        "insertSpaceAfterFunctionKeywordForAnonymousFunctions": true,
        "insertSpaceBeforeFunctionParenthesis": false,
        "insertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis": false,
        "insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": false,
        "insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": true,
        "insertSpaceAfterOpeningAndBeforeClosingTemplateStringBraces": false,
        "insertSpaceAfterOpeningAndBeforeClosingJsxExpressionBraces": false,
        "insertSpaceAfterTypeAssertion": false,
        "placeOpenBraceOnNewLineForFunctions": false,
        "placeOpenBraceOnNewLineForControlBlocks": false
    },
    "preferences": {
        "quotePreference": "single",
        "importModuleSpecifierPreference": "non-relative",
        "allowTextChangesInNewFiles": true,
        "providePrefixAndSuffixTextForRename": true,
        "allowRenameOfImportPath": true
    }
}
[Trace  - 10:53:31 AM] Response received: configure (42). Request took 6795 ms. Success: true 

We make a global configure request to ensure that any edited files have the expected configuration for settings like quotes (as we do not know which files are going to be touched before hand).

You should see the file rename dialog taking a long time to show up in VS Code. I don't know where this delay actually shows up on the tsserver as the logs show that the configure request itself is pretty quick.