Noncrashing property access through non-null assertion operator should narrow that property to NonNullable

[LeviticusMB]

TypeScript Version: 2.3 (Playground)

Code

Using strictNullChecks.

interface Foo {
    optional?: number;
}

interface Bar {
    foo?: Foo;
}

function test(bar: Bar) {
    if (bar.foo!.optional) {
        let num: number = bar.foo.optional;
    }

    if (bar.foo && bar.foo.optional) {
        let num: number = bar.foo.optional;
    }
}

Expected behavior:
No errors or warnings.

Actual behavior:

• num in first if block is number | undefined
• bar.foo in first if block can be undefined

[mhegazy]

this is behaving as intended. the ! operator is not a narrowing operator. it just muffles the error. so every time you use the variable you need to reapply !. if you want to narrow, use one of the narrowing patterns, like bar.foo && bar.foo.optional is suggested above.

[LeviticusMB]

1. Why? There is no way I can enter the first if block if either foo or optional is undefined.
2. And even so, TypeScript still thinks bar.foo!.optional inside the block can be undefined, even though I just checked that it's not. The very fact that I used ! on foo breaks the type guard on optional. See the second if block below.

[mhegazy]

The ! operator does not change the type.. it just tells the compiler, i know it is null | undefined, but i want to access it anyways.. it is similar to your regular type assertion, think of:

var x: number | string;

if (typeof (x as number).toFixed === "function") {
      (x as number).toFixed();  // need to cast again
      var y: number =  x;   // error, x is number | string
}

[RyanCavanaugh]

@mhegazy what's our excuse for not unwrapping this, though?

[RyanCavanaugh]

If we retrieved a property of an identifier, there's no reason to not consider that a truthiness guard of the same identifier. It's clearly not null / undefined

[mhegazy]

The assertion has no scope, it can appear in the middle of an expression, or in the middle of an if block, it is not clear what that means to the type for the rest of the block.. other narrowing constructs do have clear scoping semantics /control flow implications.

We did discuss this before, but i can not find the issue at the moment.

[RyanCavanaugh]

This isn't about applying the ! operator to the rest of the block. It's about this:

function test(bar: Bar) {
    if (bar.foo!.optional) {
        let num: number = bar.foo.optional; // Should not error!
    }

The dotted property access on bar.foo should act as an equivalent type guard to if (bar.foo) {, because the fact we got inside the if block without crashing means it's not null/undefined

[mhegazy]

related #9640

[LeviticusMB]

Well, it's actually about this:

    if (bar.foo!.optional) {
        let num: number = bar.foo!.optional; // "Type 'number | undefined' is not assignable to type 'number'"
    }

although it was also surprising that I have to use foo!. twice, even inside the if block.