Skip to content

Translate tsconfig basic options about output directory into Japanese #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2020

Conversation

Quramy
Copy link
Contributor

@Quramy Quramy commented Feb 19, 2020

@Quramy Quramy requested a review from orta as a code owner February 19, 2020 16:09
@@ -39,7 +39,7 @@ By setting `rootDir: "."` in `tsconfig.json`, TypeScript would write this tree:
```
MyProj
├── dist
| ├── core
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orta
I found nits typo in original doc and fix it.
(this character should be not | but )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Quramy Quramy changed the title I18n jp tsconfig in out directory options Translate tsconfig basic options about output directory into Japanese Feb 19, 2020
Copy link
Contributor

@takefumi-yoshii takefumi-yoshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@orta orta merged commit 1e3cd08 into microsoft:v2 Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants