Skip to content

[ja translation] playground-example/3-8,3-9 #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 8, 2020

Conversation

uraway
Copy link
Contributor

@uraway uraway commented Nov 25, 2020

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @sasurau4, @Quramy, @Naturalclar, and @Takepepe - if they write a comment saying "LGTM" then it will be merged.

Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

// インポートなしで使用することができます。

// でもここでは、自前で定義してみましょう。 valueという式が
// trueであることをアサートする関数を次のように定義します:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

行数を変えると元の文とのdiffがずれてしまうので、合わせてもらえると 🙏

@@ -0,0 +1,48 @@
//// { compiler: { ts: "3.8.3" } }
// 3.8では、型をインポートするための新しい構文を追加しました。
// これはflowユーザーにはおなじみのものです。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

分かりやすい 👍

Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@uraway uraway changed the title [Translation into ja] Feature/translation on 3.7, 3.8 [ja translation] playground-example/3-8,3-9 Dec 5, 2020
@sasurau4
Copy link
Contributor

sasurau4 commented Dec 8, 2020

@orta Hmm, code owners merge failed again. 👀

@orta
Copy link
Contributor

orta commented Dec 8, 2020

Boo! Sorry about that

@orta orta merged commit c762b9f into microsoft:v2 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants