This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Update packages, add tests, add type casts #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CarlosSolrac
commented
Sep 24, 2019
CarlosSolrac
commented
- Include PR "Added tests for signup and reset routes" written by alexhoffman617
- Upgrade to latest packages
- Add test script without --forceExit
- Cast req.user as UserDocument
- Update logger to use latest Winston syntax
* Include PR "Added tests for signup and reset routes" written by alexhoffman617 * Upgrade to latest packages * Add test script without --forceExit * Cast req.user as UserDocument * Update logger to use latest Winston syntax
|
|
|
CI fails look legit, but everything else seems good 👍 |
Update packages Mongoose use unified topology
|
@CarlosSolrac thanks for changes |
brittanyferderer
pushed a commit
that referenced
this pull request
Jun 17, 2022
- upgrade to latest packages - cast `req.user` as `UserDocument` - update logger to use latest Winston syntax - disable `no-inferrable-types`, Mongoose use unified topology Thx to @CarlosSolrac
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.