Add HTMLPictureElement Interface #53
Conversation
fix [HTMLPictureElement interface definition is missing #5323](microsoft/TypeScript#5323). And add relative method.
|
Hi @YuichiNukiyama, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
| @@ -2569,6 +2569,8 @@ interface Document extends Node, GlobalEventHandlers, NodeSelector, DocumentEven | |||
| * @param content The text and HTML tags to write. | |||
| */ | |||
| writeln(...content: string[]): void; | |||
| createElement(tagName: "picture"): HTMLPictureElement; | |||
There was a problem hiding this comment.
these will be ignored if they are defined here after the less specific signature: createElement(tagName: string).
@zhengbli why is the order messed up here? and how can we fix it?
There was a problem hiding this comment.
Actually the overloads wouldn't be ignored, even if they are defined after the more generic signature. The reason why the order is messed up is that the information in the json files are picked up after the emitting from the spec was done, so they are always placed at the end. I can fix it later, though it shouldn't affect the functionality now.
|
LGTM. |
Add HTMLPictureElement Interface
Co-authored-by: saschanaz <[email protected]> Co-authored-by: Kagami Sascha Rosylight <[email protected]>
fix HTMLPictureElement interface definition is missing
#5323 issue. And add
methods of Document & Element interface which related HTMLPictureElement.