Skip to content

Update build script & Correct browser package #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

zhiyuanliang-ms
Copy link
Contributor

@zhiyuanliang-ms zhiyuanliang-ms commented Jan 10, 2025

This PR does two things:

  1. Fix the failure of building packages from FeatureManagement-JavaScript repo in our OOB release pipeline.

I fail to build packages from FeatureManagement-JavaScript repo in our OOB release pipeline. It cannot execute npm install in any subfolders.(There are three packages in the JS FM repo) The log reported connection error: fail to get npm registry.

I rerun the some previous successful attempts, they fail now. After debugging, I found that if we placed the Azure.npmrc in the subfolder, then npm install and npm link can be executed as expected (no connection error any more). The possible reason could be the upgrade of agent major version. Previously, it may allow to fall back the default npm registry. but now it only allows Azure Artifact registry.

Our OOB release pipeline will use Azure Artifact registry by creating a .npmrc file in the root folder. So I update the build script to copy it to each subfolders.

  1. Correct the entry point of the browser package. It is an oversight from Fix rollup & package-lock.json #84

@zhiyuanliang-ms zhiyuanliang-ms merged commit 6a03ea6 into main Jan 14, 2025
5 checks passed
@zhiyuanliang-ms zhiyuanliang-ms deleted the zhiyuanliang/fix-package branch January 14, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants