-
Notifications
You must be signed in to change notification settings - Fork 55
Fix: preserve new baggage values in context on key conflict #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: preserve new baggage values in context on key conflict #1061
Conversation
Thanks for the pull request. It'd help to add a test (or tests) to demonstrate the cases where this was failing and is now fixed. |
@shakuzen UTs are added to demonstrate the fix. |
fd233a8
to
5f388a9
Compare
@amitsinha11 Thank for the PR, could you please also sign-off your commits so the DCO check can pass? You can read more about it by clicking on the failing check. |
…er-metrics#1061) Signed-off-by: Amit Sinha <[email protected]>
5f388a9
to
906f93d
Compare
@jonatan-ivanov done, DCO check is ok now. |
@chemicL could you review when you have a chance, in case we're missing anything from a Reactor or context-propagation perspective? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shakuzen the change looks great, I have no reservations.
@shakuzen, could you merge this if all is ok? |
It's on my list of things to do. I want to check on a few things before merging. |
…er-metrics#1061) Signed-off-by: Amit Sinha <[email protected]>
906f93d
to
9fb865b
Compare
Thanks for the pull request and quick updates on feedback. This is now merged to |
Fixes: #1060