Skip to content

feat: introduce support for Angular version 5 #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 29, 2017
Merged

feat: introduce support for Angular version 5 #439

merged 8 commits into from
Oct 29, 2017

Conversation

mgechev
Copy link
Owner

@mgechev mgechev commented Oct 23, 2017

Fix #409

@mgechev mgechev requested a review from wKoza October 23, 2017 20:19
@darkbasic
Copy link

darkbasic commented Oct 27, 2017

> [email protected] build:links /home/niko/WebstormProjects/deps/codelyzer
> ts-node build/links.ts --src ./dist

Error: Cannot find module '../../style-guide-links/all.json'
    at Function.Module._resolveFilename (module.js:513:15)
    at Function.Module._load (module.js:463:25)
    at Module.require (module.js:556:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/niko/WebstormProjects/deps/codelyzer/build/links.ts:3:15)
    at Module._compile (module.js:612:30)
    at loader (/home/niko/WebstormProjects/deps/codelyzer/node_modules/ts-node/src/index.ts:290:14)
    at Object.require.extensions.(anonymous function) [as .ts] (/home/niko/WebstormProjects/deps/codelyzer/node_modules/ts-node/src/index.ts:307:14)
    at Module.load (module.js:531:32)
    at tryModuleLoad (module.js:494:12)

I cannot manage to run npm run release from the minko/ng-v5 branch.

@darkbasic
Copy link

[niko@arch-desktop angularcli-graphql]$ git diff package.json 
diff --git a/package.json b/package.json
index 35e31f9..b41c1a6 100644
--- a/package.json
+++ b/package.json
@@ -12,27 +12,27 @@
   },
   "private": true,
   "dependencies": {
-    "@angular/animations": "^4.2.4",
-    "@angular/common": "^4.2.4",
-    "@angular/compiler": "^4.2.4",
-    "@angular/core": "^4.2.4",
-    "@angular/forms": "^4.2.4",
-    "@angular/http": "^4.2.4",
-    "@angular/platform-browser": "^4.2.4",
-    "@angular/platform-browser-dynamic": "^4.2.4",
-    "@angular/router": "^4.2.4",
+    "@angular/animations": "^5.0.0-rc.7",
+    "@angular/common": "^5.0.0-rc.7",
+    "@angular/compiler": "^5.0.0-rc.7",
+    "@angular/core": "^5.0.0-rc.7",
+    "@angular/forms": "^5.0.0-rc.7",
+    "@angular/http": "^5.0.0-rc.7",
+    "@angular/platform-browser": "^5.0.0-rc.7",
+    "@angular/platform-browser-dynamic": "^5.0.0-rc.7",
+    "@angular/router": "^5.0.0-rc.7",
     "core-js": "^2.4.1",
     "rxjs": "^5.4.2",
     "zone.js": "^0.8.14"
   },
   "devDependencies": {
     "@angular/cli": "1.5.0-rc.5",
-    "@angular/compiler-cli": "^4.2.4",
-    "@angular/language-service": "^4.2.4",
+    "@angular/compiler-cli": "^5.0.0-rc.7",
+    "@angular/language-service": "^5.0.0-rc.7",
     "@types/jasmine": "~2.5.53",
     "@types/jasminewd2": "~2.0.2",
     "@types/node": "~6.0.60",
-    "codelyzer": "~3.2.0",
+    "codelyzer": "file:../deps/codelyzer/codelyzer-3.2.1.tgz",
     "jasmine-core": "~2.6.2",
     "jasmine-spec-reporter": "~4.1.0",
     "karma": "~1.7.0",
@@ -44,6 +44,6 @@
     "protractor": "~5.1.2",
     "ts-node": "~3.2.0",
     "tslint": "~5.7.0",
-    "typescript": "~2.3.3"
+    "typescript": "~2.4.2"
   }
 }
[niko@arch-desktop angularcli-graphql]$ npm install
npm WARN [email protected] requires a peer of @angular/compiler@^2.3.1 || >=4.0.0-beta <6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/core@^2.3.1 || >=4.0.0-beta <6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/platform-browser-dynamic@^2.3.1 || >=4.0.0-beta <6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/platform-browser@^2.3.1 || >=4.0.0-beta <6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/common@^2.3.1 || >=4.0.0-beta <6.0.0 but none is installed. You must install peer dependencies yourself.

Also, why do I get the following warnings despite using Angular 5.0.0-rc.7?

@mgechev mgechev mentioned this pull request Oct 27, 2017
@mgechev
Copy link
Owner Author

mgechev commented Oct 29, 2017

@darkbasic removed one task, now you should be able to run npm run release.

@mgechev mgechev merged commit 0217e2d into master Oct 29, 2017
@mgechev mgechev deleted the minko/ng-v5 branch October 29, 2017 20:34
@diagramatics
Copy link

I think you forgot to publish to npm?

@darkbasic
Copy link

Yes please publish the updated version.

@mgechev
Copy link
Owner Author

mgechev commented Oct 30, 2017

Not published yet, will do in this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants