Skip to content

Add jfinkhaeuser/json-rpc #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Add jfinkhaeuser/json-rpc #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
630811b
WIP wrap file
jfinkhaeuser Dec 22, 2021
004e006
Tweaked some things, now it works.
jfinkhaeuser Dec 22, 2021
73d23c6
Update releases.json
jfinkhaeuser Dec 22, 2021
4dcc3aa
Add to CI configuration; set the C++17 standard
jfinkhaeuser Dec 22, 2021
29df9a1
Fix versioning in releases.json
jfinkhaeuser Dec 22, 2021
42e0665
Nope, unfortunately I want to ignore that one warning that pops up.
jfinkhaeuser Dec 22, 2021
d75caf3
Ok, so using the gitea generated tarball is a bit ugly, but it passes…
jfinkhaeuser Dec 22, 2021
5cf327d
Disable windows for now
jfinkhaeuser Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ci_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"libxml2", "libxmlpp", "lua", "lzo2", "mocklibc", "mpdecimal", "netstring-c",
"nng", "openh264", "openssl", "pcre2", "protobuf", "protobuf-c", "pugixml",
"quazip", "rdkafka", "reflex", "sdl2", "sdl2_image", "sdl2_mixer",
"sdl2_net", "sdl2_ttf", "termbox", "unit-system", "xxhash", "zstd"
"sdl2_net", "sdl2_ttf", "termbox", "unit-system", "xxhash", "zstd",
"jfinkhaeuser-json-rpc"
],

"fluidsynth": {
Expand Down Expand Up @@ -47,6 +48,12 @@
"libvulkan-dev"
]
},
"jfinkhaeuser-json-rpc": {
"build_options": [
"cpp_std=c++17"
],
"fatal_warnings": false
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of disabling warnings here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use specific warning flags rather than relying on meson doing what I want it to do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a specific concern about what meson may do here?

"liburing": {
"linux_only": true
},
Expand Down
8 changes: 8 additions & 0 deletions releases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,14 @@
"pbmtojbg85"
]
},
"jfinkhaeuser-json-rpc": {
"versions": [
"0.1.1-1"
],
"dependency_names": [
"json_rpc"
]
},
"json": {
"versions": [
"3.2.0-1",
Expand Down
8 changes: 8 additions & 0 deletions subprojects/jfinkhaeuser-json-rpc.wrap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[wrap-file]
directory = json-rpc
source_url = https://codeberg.org/jfinkhaeuser/json-rpc/archive/v0.1.1.tar.gz
source_filename = v0.1.1.tar.gz
source_hash = 88002cc87ae87d56c76e9e4bc46456198cb4dd048913d4395ee79c974e14df8d

[provide]
json_rpc = json_rpc_dep
Copy link
Member

@eli-schwartz eli-schwartz Dec 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this provides a subproject accessible declared dependency, but does not install a pkg-config file for system use or for use in projects that use a build system other than meson.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I don't particularly mind pkg-config, but it's not very high on my priority list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's trivial to add, meson has a built-in exporter for it. :)

pkgconfig = import('pkgconfig')

pkgconfig.generate(foo_lib)

There are optional kwargs that can fine tune the metadata, for example giving the project description.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note, adding a .pc file is not required. In fact if upstream does not provide one, then it makes sense to not add one at all, because otherwise people will start to depend on it existing which will cause problems.