Skip to content

Corner cases not handled correctly by normalizePath #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wrr opened this issue Jul 23, 2013 · 3 comments
Closed

Corner cases not handled correctly by normalizePath #97

wrr opened this issue Jul 23, 2013 · 3 comments

Comments

@wrr
Copy link

wrr commented Jul 23, 2013

I found following two corner cases that do not seem to be handled correctly by normalizePath():

>URI('/.//').normalizePath().toString()
'//'

>URI('/foo/..').normalizePath().toString()
'/foo/..'

I can try to write a fix, if you agree that these two should both produce /
@wrr
Copy link
Author

wrr commented Jul 23, 2013

And one more:

>URI('/.').normalizePath().toString()
'/.'

@rodneyrehm
Copy link
Member

true. Maybe @djcsdy has some htoughts on that, he already fixed a couple of edge cases (see open pull requests)

rodneyrehm added a commit that referenced this issue Aug 3, 2013
@rodneyrehm
fixing normalizePath() to properly normalize /.// to / - closes #97
a2a999a
rodneyrehm added a commit that referenced this issue Aug 3, 2013
@rodneyrehm
fixing normalizePath() to properly normalize /.// to / - closes #97
bd20c5b
@rodneyrehm
Copy link
Member

I've fixed this in master - it will be included in the next release. thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rodneyrehm @wrr