Skip to content

Implement PKCE for OpenID Connect #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhkarimi1383 opened this issue Oct 8, 2022 · 0 comments · Fixed by #474
Closed

Implement PKCE for OpenID Connect #473

mhkarimi1383 opened this issue Oct 8, 2022 · 0 comments · Fixed by #474

Comments

@mhkarimi1383
Copy link

Hi
I'm using LogTo as my OpenID Connect Provider
but I'm getting 421 status code with the error below in gitea container logs

2022/10/08 09:53:16 ...rs/web/auth/oauth.go:834:SignInOAuthCallback() [I] [63411754] Failed OAuth callback: (invalid_request) Authorization Server policy requires PKCE to be used for this request

related: go-gitea/gitea#21376

I think someone fixed that for zoom authentication #459
I think it's good to make it for OpenID Connect too...
or make it working by using LogTo library (and adding another Provider)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

openidconnect: allow overriding redirect_uri and passing code_verifier zeripath/goth
1 participant
@mhkarimi1383