-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Implement PKCE for OpenID Connect - Unable to login with LogTo #21376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Unfortunately the upstream library we use https://github.com/markbates/goth doesn't appear to implement PKCE authentication for OpenIDConnect - and therefore it looks like we don't support it. I'm not certain because although I've read the OAuth specs several times it was a while ago, but I'm not certain that it would necesarily be too difficult to implement. |
I think someone fixed that for zoom authentication markbates/goth#459 |
I created an issue in https://github.com/markbates/goth: markbates/goth#473 |
We should keep this issue open as a marker to add the changes once the associated PR is merged. |
Hello, |
Gitea now are using 1.76.0 which have included markbates/goth#474 . So this has been resolved? @zeripath @techknowlogick |
per the comment in #21426 (comment), work needs to be done on Gitea's side to be able to support this. |
Is there a milestone or ETA for this planned? I would like to use Pinniped with Gitea, but it's incompatible at the moment. |
Description
Hi,
I want to connect my Gitea instance to Logto OpenID connect
but I'm getting 421 status code with the error below in gitea container logs
I'm not able to do it in demo site since my logto instance is not fully available in public
Gitea Version
1.17.2
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Docker Container
Database
PostgreSQL
The text was updated successfully, but these errors were encountered: