Refactor expansion #140
Merged
Refactor expansion #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's make the expansion module tidy by reducing number of items located in the module.
magicant
force-pushed
the
refactor_expansion
branch
from
e89e806 to
517f149
Compare
magicant
force-pushed
the
refactor_expansion
branch
from
517f149 to
18fde22
Compare
magicant
force-pushed
the
refactor_expansion
branch
from
1c8d89c to
75bdff3
Compare
The type parameter is now the type of the interim data rather than the Expand implementor. QuickExpand now derives Debug.
This commit defines expand_word_new, expand_words_new, and expand_value_new. The "_new" suffix in the function names is a temporary workaround to avoid conflicts with the existing functions.
This commit defines perform_assignment_new and perform_assignments_new. The "_new" suffix in the function names is a temporary workaround to avoid conflicts with the existing functions.
expand_word <- expand_word_new expand_words <- expand_words_new expand_value <- expand_value_new perform_assignment <- perform_assignment_new perform_assignments <- perform_assignments_new
10 tasks
Now that no expansion functions return (), the default type parameter is useless.
magicant
force-pushed
the
refactor_expansion
branch
from
8d97c0f to
bc160ed
Compare
42 tasks
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #139