[Cms] Added a getByIdentifier() method to the BlockRepository #9163
Conversation
|
So you never tried loading a block via its identifier? Try it. It already works. |
| * @return \Magento\Cms\Api\Data\BlockInterface | ||
| * @throws \Magento\Framework\Exception\NoSuchEntityException | ||
| */ | ||
| public function getByIdentifier($blockIdentifier, $storeId); |
There was a problem hiding this comment.
Unfortunately, due to backwards compatibility policy, currently we can not add any new methods to the interfaces, specially the ones marked with the @api annotation. You may extract this method to a separate interface/class, if it is really needed.
There was a problem hiding this comment.
What do you suggest? Should I simply remove this part from the interface and let the implementation in the model ( app/code/Magento/Cms/Model/ResourceModel/Block.php ) ?
There was a problem hiding this comment.
Actually, your PR is redundant, as Magento\Cms\Api\BlockRepositoryInterface::getById('my-block-identifier') already works. As is Magento\Cms\Api\BlockRepositoryInterface::getById(12), too.
The resource model I showed you is just the place where the logic decides which route to go: identifier or numeric id? Again, try it yourself.
…in order to avoid to break backward compatibility of the API
|
@ishakhsuvarov changes are completed. |
|
Hi @enrico69 Just FYI: we are working on #7417 It should resolve your issue |
[Spartans] Bugfixes Delivery
No description provided.