magento/magento2#38659: Change order status issue

[BeggiNN]

• Fixed issue with changing order status

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes [Issue] Cannot update Order status in 2.4.7 #38659
2. Fixes Cannot change intermediate custom status in admin using add comment form #38917

Manual testing scenarios (*)

1. Install vanilla Magento
2. Go to admin Stores => Order Status
3. Create two statuses "Sent" and "Ready for Pickup" and bind them to "Processing" state
4. Create product and register customer
5. Place order on front using this product and customer and default shipping and payment methods
6. Go to admin Sales => Orders
7. Open previously placed order
8. Create invoice by clicking Invoice button on top
9. See order changed status to "Processing"
10. Go to "Add Comment" form change status to "Sent" and add any comment
11. Reload order form and see status changed to "Sent"
12. Go to "Add Comment" form again and change status to "Ready for Pickup" and add any comment
13. Reload order form

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @BeggiNN. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[BeggiNN]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @BeggiNN,

Thanks for your contribution!

It seems that the build failures are due to PR changes, please look into it.

Thanks

[engcom-Hotel]

@magento run Static Tests, Unit Tests, Integration Tests

[BeggiNN]

@engcom-Hotel Yes, I will rework the unit tests soon.

[engcom-Hotel]

@magento run Unit Tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE

[engcom-Hotel]

@magento run all tests

[engcom-Bravo]

@magento give me test instance

[magento-deployment-service]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Bravo, here is your Magento Instance: https://906222cbd2c0df8cfab04c6745494c87.instances-prod.magento-community.engineering
Admin access: https://906222cbd2c0df8cfab04c6745494c87.instances-prod.magento-community.engineering/admin_c5a4
Login: fb43e730
Password: dc116064bdc0

[engcom-Bravo]

Hi @BeggiNN,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

As per the Description

Before: ✖️ 

Screen.Recording.2024-07-12.at.12.19.23.mov

After: ✔️

Screen.Recording.2024-09-03.at.13.07.22.mov

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests EE

[engcom-Charlie]

Functional B2B failures in recent 2 builds are not constant and one consistent failure is a known issue.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38923/5117af6736482c83543b2e44c9abaa46/Functional/allure-report-b2b/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38923/021f7465a77ed23032494110c40e7e8d/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

Known issues :
AdminCreateDraftQuoteFromQuoteGridPageTest: #ACQE-6309

[engcom-Charlie]

Some build failures from functional EE are not constant in recent 2 builds, seems to be flaky. One failure is constant and its a known issue. Hence moving this PR to Merge in Progress.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38923/5103f08befc51821ce422671547d4228/Functional/allure-report-ee/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38923/6247a086b89182e6ce8ce256eb1a73fb/Functional/allure-report-ee/index.html#categories

Known issues :
StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest: #ACQE-6331

[hostep]

Was fixed by internal Adobe devs in 18dee3d, so we can probably close this PR?

[engcom-Charlie]

Was fixed by internal Adobe devs in 18dee3d, so we can probably close this PR?

Seems to be fixed in 18dee3d under ACP2E-3178 hence closing it now.