#38659 - Fix order status update

[Nuranto]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes [Issue] Cannot update Order status in 2.4.7 #38659

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Nuranto. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[Nuranto]

@magento run all tests

[pbrouwers]

@Nuranto can you include a revert of the broken code here? 632f253

[Nuranto]

Actually, looking at this code, I wonder if we shouldn't take the opportunity to do a more thorough refactoring. This PR is a conveninent quick fix for the issue, but there's more to do :

The AddComment controller should use the OrderService::addComment service, and the state/status check that I added here should be done in the Order::addStatusHistory class. We will then need to revise the tests accordingly....

It's a too big task for me, especially without being sure that the PR will be approved, I think it would be worth asking for the opinion of the Magento architects.

What do you think ?

[YiffyToys]

So the static test is basically complaining about the @param in the method comment.
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38661/a1e071315a06ec25f7ffe9f8af1a0e82/Statics/console-error-logs.html

One of the unit tests looks interesting.
"Call to a member function getStateStatuses() on null"
That means "$order->getConfig()" was null.
I'm not sure that can happen outside a unit test.
(The test may have failed to set up the order config.)
But it's easy to handle by just skipping the check to make the code bullet proof.

$config =$order->getConfig()
if (is_null($config)) {
   // TODO: log about order config being null and include order-id in the log message
    return $historyStatus;
}
$statuses =config->getStateStatuses($order->getState());

https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38661/2eb55eff5d856c66daecb1d8c35717c3/Unit/allure-report-b2b/index.html#categories/79ed4d6211c69c293e7e7274e32246b1/15a9a1dca4ce89f4/

the B2B functional test looks like it was broken by something completely different and unrelated.
"CSS or XPath element with //section[@id='order-items']/div/div/button/span[text() = 'Add Products'] was not found."

same for the EE functional test
"There was '#super-product-table .product-item-name' element on page /api-grouped-product662a71e6e0ec82.html

• Api Simple Product662a71e757c5d2
  containing 'Api Simple Product662a71e757c5d2'"

The Web-API test could be unrelated. Maybe even the test itself is outdated.
"1) Magento\GraphQl\NegotiableQuote\SendNegotiableQuoteForReviewTest::testSendNegotiableQuoteCannotResend
Failed asserting that exception of type "Exception" is thrown."
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38661/120e2a1451cdcf961a7d5080c3da67a0/WebApi/console-error-logs.html

[YiffyToys]

So what developer is going to pick this up, make the 2 trivial changes and run the tests again?
As merchants we are a user and have enough work of our own.
(And no time to work our way through a complex Adobe license agreement to be allowed to clone the repository.)

[engcom-Hotel]

Hello @Nuranto,

As you said here #38661 (comment), more refactoring is required on this PR for now. Hence we are closing this PR. Please let us know whenever you are ready with this, we will reopen it.

Thanks