Skip to content

Mitigate performance issue in #36667 during price indexing #38050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions app/code/Magento/CatalogInventory/Model/Plugin/ProductLinks.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,29 +13,22 @@

class ProductLinks
{
/**
* @var Configuration
*/
private $configuration;

/**
* @var Stock
*/
private $stockHelper;

/**
* ProductLinks constructor.
*
* @param Configuration $configuration
* @param Stock $stockHelper
*/
public function __construct(Configuration $configuration, Stock $stockHelper)
{
$this->configuration = $configuration;
$this->stockHelper = $stockHelper;
public function __construct(
private readonly Configuration $configuration,
private readonly Stock $stockHelper
) {
}

/**
* Fixes simple products are shown as associated in grouped when set out of stock
*
* @param Link $subject
* @param Collection $collection
* @return Collection
Expand All @@ -44,7 +37,7 @@ public function __construct(Configuration $configuration, Stock $stockHelper)
public function afterGetProductCollection(Link $subject, Collection $collection)
{
if ($this->configuration->isShowOutOfStock() != 1) {
$this->stockHelper->addInStockFilterToCollection($collection);
$this->stockHelper->addIsInStockFilterToCollection($collection);
}
return $collection;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function testAfterGetProductCollectionShow($status, $callCount)
$this->configMock->expects($this->once())->method('isShowOutOfStock')->willReturn($status);
$this->stockHelperMock
->expects($this->exactly($callCount))
->method('addInStockFilterToCollection')
->method('addIsInStockFilterToCollection')
->with($collectionMock);

$this->assertEquals($collectionMock, $this->model->afterGetProductCollection($subjectMock, $collectionMock));
Expand Down