Increase precision of USPS shipping weight ounces calculation #3467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (potential) fix for issue #3465
Essentially, a small shipping weight is rounded down to 0 lbs, 0 oz by the USPS shipping module, which kicks back an error from USPS. According to the USPS pricing api docs, 10 digits are allowed to be passed to the ounces field.
This pull request changes the rounding precision to 10. This is not necessarily the best nor only way to fix this - I think there is an argument to be made that no rounding should be performed at all (there is no rounding performed on the FedEx shipping weight, for example). However, I wanted to err on the side of caution and merely change the precision of the
round
function rather than removing it entirely.Reproducing the bug is simple:
debug.log
is also helpful)