Skip to content

Fixes to launch Magento with PHP 8.1 - part 4 #34641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 25, 2021
Merged

Fixes to launch Magento with PHP 8.1 - part 4 #34641

merged 5 commits into from
Nov 25, 2021

Conversation

karyna-t
Copy link
Contributor

@karyna-t karyna-t commented Nov 15, 2021 •
edited
Loading

Description (*)

Fixes for compatibility with PHP 8.1 (to be able to launch Magento)
Part 4

Related Pull Requests

Related Issues

  1. Add fixes Magento to run on PHP 8.1 #34505

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 15, 2021

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-github-services m2-github-services added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 15, 2021
@karyna-t karyna-t changed the title Fix magento to launch with php8.1 - part 4 [WIP] Fixes to launch Magento with PHP 8.1 - part 4 Nov 15, 2021
@karyna-t karyna-t force-pushed the fix-magento-to-launch-with-php8.1-part4 branch from 87d14bf to 013abfc Compare November 15, 2021 19:13
@karyna-t karyna-t changed the title [WIP] Fixes to launch Magento with PHP 8.1 - part 4 Fixes to launch Magento with PHP 8.1 - part 4 Nov 15, 2021
@andrewbess andrewbess self-assigned this Nov 15, 2021
@andrewbess andrewbess added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: pending review Project: Platform Health and removed Progress: review labels Nov 15, 2021
@karyna-t karyna-t force-pushed the fix-magento-to-launch-with-php8.1-part4 branch from 013abfc to f4e31b3 Compare November 15, 2021 19:49
@xmav
Copy link
Contributor

xmav commented Nov 15, 2021

@mageto run Static Tests, Semantic Version Checker

2 similar comments
@karyna-t
Copy link
Contributor Author

@mageto run Static Tests, Semantic Version Checker

@andrewbess
Copy link
Contributor

@mageto run Static Tests, Semantic Version Checker

@andrewbess andrewbess mentioned this pull request Nov 17, 2021
Closed
5 tasks
@karyna-t karyna-t force-pushed the fix-magento-to-launch-with-php8.1-part4 branch 2 times, most recently from a76370e to 82ecfc0 Compare November 18, 2021 09:49
@karyna-t karyna-t force-pushed the fix-magento-to-launch-with-php8.1-part4 branch from 82ecfc0 to 422a871 Compare November 18, 2021 13:58
@karyna-t
Copy link
Contributor Author

@magento run Static Tests with env PHP 8.1

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@karyna-t
Copy link
Contributor Author

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

fascinosum
fascinosum requested changes Nov 18, 2021
View reviewed changes
@andrewbess
Copy link
Contributor

@magento run Static tests, Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

fascinosum
fascinosum requested changes Nov 23, 2021
View reviewed changes
@andrewbess
Copy link
Contributor

@magento run Static tests, Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Nov 24, 2021

@magento run Unit Tests, Unit Tests with env PHP 7.4

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Nov 24, 2021

@magento run Unit Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess
andrewbess approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @karyna-tsymbal-atwix
Thank you for your work here
It looks well from my side
Approved ✔️

@xmav
Copy link
Contributor

xmav commented Nov 24, 2021

@magento import code to magento-trigger/magento2ce

@m2-github-services
Copy link
Collaborator

@xmav the branch with the code is successfully imported into the magento-trigger/magento2ce repository. Branch name: imported-karyna-tsymbal-atwix-magento2-34641.

@andrewbess andrewbess changed the base branch from platform-health to 2.4-develop November 24, 2021 07:06
@andrewbess andrewbess changed the base branch from 2.4-develop to platform-health November 24, 2021 07:06
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 18b5b23 into magento:platform-health Nov 25, 2021
@karyna-t karyna-t deleted the fix-magento-to-launch-with-php8.1-part4 branch November 26, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fascinosum fascinosum fascinosum approved these changes

@andrewbess andrewbess andrewbess approved these changes

Assignees

@fascinosum fascinosum

@andrewbess andrewbess

Labels
Award: category of expertise Award: special achievement Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for testing Project: Platform Health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@karyna-t @xmav @andrewbess @m2-github-services @fascinosum @magento-devops-reposync-svc