Skip to content

Replace repetitive actions with Action Groups in AdminCreateDuplicateCategoryTest and AdminCreateDuplicateProductTest #34410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2021
Merged

Replace repetitive actions with Action Groups in AdminCreateDuplicateCategoryTest and AdminCreateDuplicateProductTest #34410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9972de0
Reusing existing ActionGroup
kate-kyzyma Oct 22, 2021
c934b51
Refactoring-AdminCreateDuplicateProductTest
kate-kyzyma Oct 22, 2021
ef654e5
Merge branch '2.4-develop' into Refactoring-AdminCreateDuplicateCateg…
kate-kyzyma Oct 25, 2021
1faca01
Change stepKey
kate-kyzyma Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateDuplicateCategoryTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
</actionGroup>

<!-- Assert error message -->
<see selector="{{AdminCategoryMessagesSection.errorMessage}}" userInput="The value specified in the URL Key field would generate a URL that already exists." stepKey="seeErrorMessage"/>
<actionGroup ref="AssertMessageInAdminPanelActionGroup" stepKey="seeErrorMessage">
<argument name="messageType" value="error"/>
<argument name="message" value="The value specified in the URL Key field would generate a URL that already exists."/>
</actionGroup>
</test>
</tests>
5 changes: 4 additions & 1 deletion app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateDuplicateProductTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@

<!-- Save the product and expect to see an error message -->
<actionGroup ref="SaveProductFormNoSuccessCheckActionGroup" stepKey="tryToSaveProduct"/>
<see selector="{{AdminProductFormSection.successMessage}}" userInput="The value specified in the URL Key field would generate a URL that already exists." stepKey="seeErrorMessage"/>
<actionGroup ref="AssertMessageInAdminPanelActionGroup" stepKey="seeErrorMessage">
<argument name="messageType" value="error"/>
<argument name="message" value="The value specified in the URL Key field would generate a URL that already exists."/>
</actionGroup>
</test>
</tests>