Skip to content

33800: Fixed issue with print invoice on customer account #34211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

33800: Fixed issue with print invoice on customer account #34211

wants to merge 3 commits into from

Conversation

AZiniukhin
Copy link
Contributor

Description (*)

Added a check to output a client-oriented error message.
Screenshot 2021-09-30 at 22 29 09

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Issue with print invoice #33800

Manual testing scenarios (*)

  1. Create an Order from front-end
  2. View Order from Front-end
  3. Print Order - No issue http://magento2.4.local/default/sales/order/print/order_id/37/ - User is able to print Order and save
  4. Access below Print invoice URL before the invoice is generated (using any new ID in the URL)
    /sales/order/printInvoice/invoice_id/7/

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 30, 2021

Hi @AZiniukhin. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. labels Sep 30, 2021
Den4ik
Den4ik requested changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AZiniukhin Thanks for PR.
Please look at my comments

app/code/Magento/Sales/Controller/AbstractController/PrintInvoice.php Outdated
*/
protected $_coreRegistry;
protected $coreRegistry;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change protected property name because it's BIC changes

cjnewbs
cjnewbs reviewed Oct 2, 2021
View reviewed changes
app/code/Magento/Sales/Controller/AbstractController/PrintInvoice.php Outdated
Comment on lines 61 to 65
Registry $registry,
PageFactory $resultPageFactory,
InvoiceRepositoryInterface $invoiceRepository,
Session $session,
Order $order
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the additional indentation be removed please? If more dependancies are added this could result in all the indentation for the dependancies having to be re-lined up.

app/code/Magento/Sales/Controller/AbstractController/PrintInvoice.php Outdated
$order = $invoice->getOrder();
} else {
$orderId = (int)$this->getRequest()->getParam('order_id');
$order = $this->_objectManager->create(\Magento\Sales\Model\Order::class)->load($orderId);
$order = $this->order->load($orderId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change \Magento\Sales\Model\Order to \Magento\Sales\Api\OrderRepositoryInterface

Den4ik
Den4ik requested changes Oct 12, 2021
View reviewed changes
app/code/Magento/Sales/Controller/AbstractController/PrintInvoice.php
Comment on lines +66 to +68
InvoiceRepositoryInterface $invoiceRepository,
Session $session,
OrderRepositoryInterface $order
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change it according Backward Compatibility https://devdocs.magento.com/contributor-guide/backward-compatible-development/#backward-compatibility-policy

@ishakhsuvarov
Copy link
Contributor

Hi

I am closing this PR for now as it seems like it has become stale and still needs work.

Please feel free to reopen if you wish to continue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnewbs cjnewbs cjnewbs left review comments

@Den4ik Den4ik Den4ik requested changes

Assignees

@Den4ik Den4ik

@cjnewbs cjnewbs

Labels
Component: Sales Priority: P3 May be fixed according to the position in the backlog. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with print invoice
5 participants
@AZiniukhin @ishakhsuvarov @Den4ik @cjnewbs @magento-engcom-team