-
Notifications
You must be signed in to change notification settings - Fork 9.4k
createCustomer validation requirements #28888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-engcom-team
merged 7 commits into
magento:2.4-develop
from
michalderlatka:28570_createcustomer_graphql_schema
Jul 16, 2020
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1943018
magento/magento2#28570: createCustomer does not match validation requ…
michalderlatka 887f191
Merge branch '2.4-develop' of https://github.com/magento/magento2 int…
michalderlatka b5208cd
magento/magento2#28570: createCustomer does not match validation requ…
michalderlatka 0f7d805
magento/magento2#28570: createCustomer does not match validation requ…
michalderlatka 592f5de
magento/magento2#28570: createCustomer does not match validation requ…
michalderlatka 3a4cfa1
magento/magento2#28570: createCustomer does not match validation requ…
michalderlatka 2e77e22
Merge branch '2.4-develop' into 28570_createcustomer_graphql_schema
cpartica File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
93 changes: 93 additions & 0 deletions
93
app/code/Magento/CustomerGraphQl/Model/Resolver/UpdateCustomerEmail.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
<?php | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
declare(strict_types=1); | ||
|
||
namespace Magento\CustomerGraphQl\Model\Resolver; | ||
|
||
use Magento\CustomerGraphQl\Model\Customer\ExtractCustomerData; | ||
use Magento\CustomerGraphQl\Model\Customer\GetCustomer; | ||
use Magento\CustomerGraphQl\Model\Customer\UpdateCustomerAccount; | ||
use Magento\Framework\GraphQl\Config\Element\Field; | ||
use Magento\Framework\GraphQl\Exception\GraphQlAuthorizationException; | ||
use Magento\Framework\GraphQl\Query\Resolver\Value; | ||
use Magento\Framework\GraphQl\Query\ResolverInterface; | ||
use Magento\Framework\GraphQl\Schema\Type\ResolveInfo; | ||
use Magento\GraphQl\Model\Query\ContextInterface; | ||
|
||
/** | ||
* Customer email update, used for GraphQL request processing | ||
*/ | ||
class UpdateCustomerEmail implements ResolverInterface | ||
{ | ||
/** | ||
* @var GetCustomer | ||
*/ | ||
private $getCustomer; | ||
|
||
/** | ||
* @var UpdateCustomerAccount | ||
*/ | ||
private $updateCustomerAccount; | ||
|
||
/** | ||
* @var ExtractCustomerData | ||
*/ | ||
private $extractCustomerData; | ||
|
||
/** | ||
* @param GetCustomer $getCustomer | ||
* @param UpdateCustomerAccount $updateCustomerAccount | ||
* @param ExtractCustomerData $extractCustomerData | ||
*/ | ||
public function __construct( | ||
GetCustomer $getCustomer, | ||
UpdateCustomerAccount $updateCustomerAccount, | ||
ExtractCustomerData $extractCustomerData | ||
) { | ||
$this->getCustomer = $getCustomer; | ||
$this->updateCustomerAccount = $updateCustomerAccount; | ||
$this->extractCustomerData = $extractCustomerData; | ||
} | ||
|
||
/** | ||
* Resolve customer email update mutation | ||
* | ||
* @param \Magento\Framework\GraphQl\Config\Element\Field $field | ||
* @param \Magento\Framework\GraphQl\Query\Resolver\ContextInterface $context | ||
* @param ResolveInfo $info | ||
* @param array|null $value | ||
* @param array|null $args | ||
* @return array|Value | ||
* @throws \Exception | ||
* @SuppressWarnings(PHPMD.UnusedFormalParameter) | ||
*/ | ||
public function resolve( | ||
Field $field, | ||
$context, | ||
ResolveInfo $info, | ||
array $value = null, | ||
array $args = null | ||
) { | ||
/** @var ContextInterface $context */ | ||
if (false === $context->getExtensionAttributes()->getIsCustomer()) { | ||
throw new GraphQlAuthorizationException(__('The current customer isn\'t authorized.')); | ||
} | ||
|
||
$customer = $this->getCustomer->execute($context); | ||
$this->updateCustomerAccount->execute( | ||
$customer, | ||
[ | ||
'email' => $args['email'] ?? null, | ||
'password' => $args['password'] ?? null | ||
], | ||
$context->getExtensionAttributes()->getStore() | ||
); | ||
|
||
$data = $this->extractCustomerData->execute($customer); | ||
|
||
return ['customer' => $data]; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,7 +123,7 @@ public function testCreateCustomerIfInputDataIsEmpty() | |
mutation { | ||
createCustomer( | ||
input: { | ||
|
||
} | ||
) { | ||
customer { | ||
|
@@ -339,7 +339,9 @@ public function testCreateCustomerSubscribed() | |
public function testCreateCustomerIfCustomerWithProvidedEmailAlreadyExists() | ||
{ | ||
$this->expectException(\Exception::class); | ||
$this->expectExceptionMessage('A customer with the same email address already exists in an associated website.'); | ||
$this->expectExceptionMessage( | ||
'A customer with the same email address already exists in an associated website.' | ||
); | ||
|
||
$existedEmail = '[email protected]'; | ||
$password = 'test123#'; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.