Skip to content

fix for the #24618 Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/paypal.js accessing undefined variables #24622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

speedupmate
Copy link
Contributor

fix for the #24618 Magento/Braintree/view/frontend/web/js/view/payment/method-renderer/paypal.js accessing undefined variables . Adding variable _.isUndefined check

Description (*)

Fixes issue where Magento_Braintree payment method is loaded when shipping address object is not filled with all address data jet . Adds additional variable check to the mix to validate if address.street is defined with _.isUndefined

Fixed Issues (if relevant)

  1. Magento_Braintree/js/view/payment/method-renderer/paypal.js accessing undefined variables #24618: Magento_Braintree/js/view/payment/method-renderer/paypal.js accessing undefined variables

@speedupmate speedupmate requested a review from DrewML as a code owner September 16, 2019 14:39
@m2-assistant
Copy link

m2-assistant bot commented Sep 16, 2019

Hi @speedupmate. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned sidolov Sep 16, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5849 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@speedupmate thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Delta
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Delta, here is your new Magento instance.
Admin access: https://pr-24622.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Sep 20, 2019

Hi @speedupmate, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 20, 2019
@speedupmate speedupmate deleted the 24618 branch September 20, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants