Skip to content

Resolve Scope icon and store view specific label text alignment issue (issue24440) #24449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve Scope icon and store view specific label text alignment issue #24440: Scope icon and store view specific label text alignment issue

Fixed Issues (if relevant)

  1. Scope icon and store view specific label text alignment issue #24440: Scope icon and store view specific label text alignment issue

Manual testing scenarios (*)

  1. Admin -> Store -> Settings -> Order status -> Create new status

Expected result

Store View Specific Labels and scope (?) should aligned properly

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@edenduong edenduong force-pushed the 2.3-bugfix/scope_icon_alignment_issue24440 branch 2 times, most recently from a965a60 to fd7ea5f Compare September 4, 2019 16:25
@edenduong edenduong force-pushed the 2.3-bugfix/scope_icon_alignment_issue24440 branch from fd7ea5f to 4314d4b Compare September 4, 2019 16:27
@magento magento deleted a comment from magento-engcom-team Sep 4, 2019
@magento magento deleted a comment from magento-engcom-team Sep 4, 2019
@magento magento deleted a comment from magento-engcom-team Sep 4, 2019
@magento magento deleted a comment from magento-engcom-team Sep 4, 2019
@edenduong
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-24449.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5784 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sudheers-kensium sudheers-kensium self-assigned this Sep 5, 2019
@ghost ghost unassigned sudheers-kensium Sep 5, 2019
@ghost
Copy link

ghost commented Sep 5, 2019

@sudheers-kensium unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Sep 7, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 7, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scope icon and store view specific label text alignment issue
7 participants