Skip to content

24152 : fixed spacing issue #24159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

sunilit42
Copy link
Contributor

Fix issue:- #24152

@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2019

Hi @sunilit42. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@kalpmehta
Copy link
Contributor

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@kalpmehta kalpmehta self-assigned this Aug 18, 2019
@kalpmehta kalpmehta self-requested a review August 18, 2019 04:41
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, here is your Magento instance.
Admin access: https://i-24159-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-5654 has been created to process this Pull Request
✳️ @kalpmehta, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@kalpmehta
Copy link
Contributor

Thanks @sunilit42 for the contribution.

This PR removes margin left on some admin screens as it is not consistent.
@sidolov Can you please check if extra margin is required or it's ok to remove as there is already a padding? Thanks!

@engcom-Foxtrot engcom-Foxtrot self-assigned this Aug 20, 2019
@engcom-Foxtrot
Copy link
Contributor

Hello, @sunilit42. Thank you for your contribution.
Unfortunately, we cannot accept your PR. We should not remove the left margin for support text. Instead of it, we need to add such margin for cases we don't have it (for UI component grids).

@sunilit42
Copy link
Contributor Author

Hello @engcom-Foxtrot
can you please give one example where it will use? so i can do css based on that

@sunilit42
Copy link
Contributor Author

@engcom-Foxtrot any update here?

@engcom-Foxtrot
Copy link
Contributor

@sunilit42 please see #24359

@m2-assistant
Copy link

m2-assistant bot commented Sep 6, 2019

Hi @sunilit42, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants