Skip to content

#23766 - fix pattern validation on form submit #23767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2019
Merged

#23766 - fix pattern validation on form submit #23767

merged 1 commit into from
Sep 26, 2019

Conversation

vahir2016
Copy link
Contributor

On checkout cart validation submit with Jquery, fix pattern validation bug

Description (*)

Force param to be interpreted as regex.

Fixed Issues (if relevant)

  1. magento/magento2#<23766>: On checkout cart submit, pattern regex validation fails

Manual testing scenarios (*)

  1. On checkout cart page, use input type text for quantity and use pattern like "[0-9]"
  2. Bind jquery submit to submit form on input change
  3. The form should submit with no error in broswer console

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 18, 2019

Hi @vahir2016. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 18, 2019

CLA assistant check
All committers have signed the CLA.

@vahir2016
Copy link
Contributor Author

Hello,

Done.

@vahir2016
Copy link
Contributor Author

Hello,

This is my first PR for Magento, should I do something more ?

Ty

@ghost ghost assigned sidolov Aug 7, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 7, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5557 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@vahir2016 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@vahir2016
Copy link
Contributor Author

Hello,

Done.

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Sep 26, 2019

Hi @vahir2016, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants