When setting background for labels explicitly the labels in admin will

[TomashKhamlai]

When setting background for labels explicitly the labels in admin will
overlap the ::before pseudo-element.

I suggest to remove explicit setting for label element or replace
@color-white to transparent.

In some cases developers try to hide elements by setting white
background and higher z-index for the element with white background.
But the proper way of hiding elements is to override templates config or
remove elements by JavaScript.

Description (*)

Fix for the minor UI regression bug introduced in 5d3870a.

Fixed Issues (if relevant)

Before:

After:

Manual testing scenarios (*)

1. Check that app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminConfigurableProductCreateTest.xml is passing.
2. Check that fix in 5d3870a still works.

Additional Scenario

1. Create custom attribute Yes/No for example
2. Create attribute set based on default and place that attribute after Price attribute
3. Create simple product with that attribute set and save it
4. Edit the product
5. Switch attribute to Default
6. Switch back again

Expected result: Attribute Weight is visible

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @TomashKhamlai. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-4530 has been created to process this Pull Request

[TomashKhamlai]

Updated testing scenario

[VasylShvorak]

✔️ QA passed

[ghost]

Hi @TomashKhamlai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.