Skip to content

Fix numeric translation keys being dissolved by array_merge #18968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tdgroot
Copy link
Member

@tdgroot tdgroot commented Oct 31, 2018

Description (*)

When creating translations like "100","Hundred", the key "100" will be dissolved by array_merge when combining all the dictionaries from all language packs. For example, the new key of that translation could be 1, 2, etc.

Manual testing scenarios (*)

  1. Create a translation like "100","Hundred".
  2. Check if if the key "100" translates to "Hundred".

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @tdgroot. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Oct 31, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 31, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3343 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @tdgroot. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@tdgroot tdgroot deleted the fix_numeric_translation_keys branch November 9, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants