Braintree Paypal Review: check if variable is array when validating request data

[deninchoo]

Description (*)

In some cases when the Magento/Braintree/Paypal/Review.php class gets executed, the $requestData = json_decode( $this->getRequest()->getPostValue('result', '{}'), true ); does not get declared as an array as the requested post value returns a null, causing the validateRequestData($requestData) function call to produce the TypeError: Uncaught exception as the function expects the passed variable $requestData to be an array.

This pull request introduces changes that ensure there are no exceptions when a null value is passed to the validateRequestData($requestData) function.

Fixed Issues (if relevant)

1. n/a

Manual testing scenarios (*)

1. n/a

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @deninchoo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

@deninchoo thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[orlangur]

Instead of changing this function, please fix a place where it is called

does not get declared as an array as the requested post value returns a null, causing the validateRequestData($requestData)

[rogyar]

Not sure it's the best way to go. It's a private method and its purpose is to validate the request data. So, checking the type might be a part of the validation. It looks like an overhead to create an additional validation alongside with the method-validator.

[magento-engcom-team]

Hi @deninchoo. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.