Skip to content

[Backport] Improve code quality subscriber new action #18433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2018
Merged

[Backport] Improve code quality subscriber new action #18433

merged 1 commit into from
Oct 8, 2018

Conversation

lewisvoncken
Copy link
Contributor

Original Pull Request

#17232

  • Refactor else block for returning success message to private function
  • Remove not thrown @thrown tag and add missing @thrown tag
  • Use import statements for classes
  • Because imports are being used an if statement can be written on one line
  • Use addExceptionMessage and addSuccessMessage instead of their deprecated counterparts

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@arnoudhgz @lewisvoncken
Improve code quality for Subscriber/NewAction
8e22676 
+ Refactor `else` block for returning success message to private function
+ Use import statements for classes
+ Because imports are being used an `if` statement can be written on one line
+ Use `addExceptionMessage` and `addSuccessMessage` instead of their deprecated counterparts
+ Include with DI the `Magento\Framework\Validator\EmailAddress` class
which can be used to validate the email address. Therefore the static
function call to the `is` method on the `Zend_Validate` class is not
needed anymore.
@rogyar rogyar self-assigned this Oct 7, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 7, 2018
@magento-engcom-team magento-engcom-team merged commit 8e22676 into magento:2.2-develop Oct 8, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 8, 2018
ENGCOM-3120: [Backport] Improve code quality subscriber new action #1…
5b309a5 
…8433
@magento-engcom-team
Copy link
Contributor

Hi @lewisvoncken. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @lewisvoncken. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rogyar rogyar

Labels
Component: Newsletter Event: squashtoberfest Partner: Experius partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.8
Development

Successfully merging this pull request may close these issues.
4 participants
@lewisvoncken @magento-engcom-team @rogyar @arnoudhgz