Skip to content

Add checkout_cart_product_add_before event #17830 #18080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2018
Merged

Add checkout_cart_product_add_before event #17830 #18080

merged 4 commits into from
Oct 25, 2018

Conversation

leandro-rosa
Copy link
Contributor

Add checkout_cart_product_add_before event #17830

Description

Add dispatch event checkout_cart_product_add_before

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 16, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @leandro-rosa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

This was referenced Sep 16, 2018
Closed
Closed
@okorshenko okorshenko self-assigned this Sep 16, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Sep 16, 2018
@magento-engcom-team
Copy link
Contributor

@leandro-rosa thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ishakhsuvarov ishakhsuvarov modified the milestone: Release: 2.3.1 Sep 18, 2018
@okorshenko okorshenko mentioned this pull request Sep 18, 2018
Closed
@okorshenko
Copy link
Contributor

Hi @leandro-rosa
Could you please fix broken tests so that we can proceed with PR acceptance. We agreed to accept new event

Thank you

@sidolov
Copy link
Contributor

sidolov commented Oct 4, 2018

Hi @leandro-rosa , will you continue work with PR?
Thank you!

@magento-engcom-team magento-engcom-team merged commit 0de795a into magento:2.3-develop Oct 25, 2018
@magento-engcom-team
Copy link
Contributor

Hi @leandro-rosa. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

magento-engcom-team pushed a commit that referenced this pull request Oct 25, 2018
ENGCOM-2987: Add checkout_cart_product_add_before event #17830 #18080
db3a449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
Award: bug fix Component: Checkout Event: CD-Webjump Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
6 participants
@leandro-rosa @magento-cicd2 @magento-engcom-team @okorshenko @sidolov @ishakhsuvarov