Skip to content

Fix title position on my account page #16787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

iGerchak
Copy link
Contributor

Description

Fix for #16786

Fixed Issues (if relevant)

  1. Page title on the my account page moved to bottom #16786: Page title on the my account page moved to bottom

Manual testing scenarios

  1. see Page title on the my account page moved to bottom #16786

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 13, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @iGerchak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

New incarnation of #10965, @ihor-sviziev knows the details and will try to assist with a proper fix (i.e. when layout element is first referenced and only then created as a part of Magento_Theme layout instructions, it's position is correct just like if Magento_Theme was declared first).

@orlangur
Copy link
Contributor

orlangur commented Aug 2, 2018

@ihor-sviziev did you manage to move further on this?

@ihor-sviziev
Copy link
Contributor

@orlangur unfortunately no :(

@ihor-sviziev
Copy link
Contributor

As we discussed with @iGerchak and @orlangur - it's not proper solution. We should implement fix that will prevent braking layout updates when sort order in config.php changes.
I'm closing this PR. Feel free to prepare another PR

@ihor-sviziev ihor-sviziev self-assigned this Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants