[Forwardport] Fixed Datetime Error on Newsletter Template #15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

patelnimesh1988 wants to merge 1 commit into magento:2.3-develop from patelnimesh1988:2.3-develop-PR-port-15783

Contributor

patelnimesh1988 commented Jun 5, 2018

Original Pull Request

#15783
Fixed Datetime Error on Newsletter Template

Description

While save Queue Newsletter Queue Date Start Magento throw DateTime parse error. I have fixed that issue using Zend_Date class

Fixed Issues (if relevant)

Datetime Error on Newsletter Template #5037: Datetime Error on Newsletter Template

Manual testing scenarios

Login in Admin
Click on Top right corner admin name then click on Account Setting.
Change admin Interface Locale to Italiano (Svizzera) / italiano (Svizzera)
Go to Admin->Marketing->Newsletter Template
Select "Queue Newsletter" from right dropdown
Select a "Queue Date Start" and try to save it

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)


          Fixed Datetime Error on Newsletter Template

bf657cc

patelnimesh1988 added Release Line: 2.3 forwardport labels

magento-engcom-team added the Component: Framework/Stdlib label

orlangur self-assigned this

orlangur added the Progress: on hold label

Contributor

orlangur commented Jun 20, 2018

Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened.

orlangur closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Framework/Stdlib Progress: on hold Release Line: 2.3