Skip to content

[Forwardport] Fixed Datetime Error on Newsletter Template #15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patelnimesh1988
Copy link
Contributor

Original Pull Request

#15783
Fixed Datetime Error on Newsletter Template

Description

While save Queue Newsletter Queue Date Start Magento throw DateTime parse error. I have fixed that issue using Zend_Date class

Fixed Issues (if relevant)

  1. Datetime Error on Newsletter Template #5037: Datetime Error on Newsletter Template

Manual testing scenarios

  1. Login in Admin
  2. Click on Top right corner admin name then click on Account Setting.
  3. Change admin Interface Locale to Italiano (Svizzera) / italiano (Svizzera)
  4. Go to Admin->Marketing->Newsletter Template
  5. Select "Queue Newsletter" from right dropdown
  6. Select a "Queue Date Start" and try to save it

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur
Copy link
Contributor

Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened.

@orlangur orlangur closed this Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants