Skip to content

6305 - Resolved product custom option title save issue #15357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2018

Conversation

Madhumalak
Copy link
Contributor

Resolved product custom option's title save issue when the title is set to zero.

Description:

Navigate Admin => Catalog => Products => Create New / Edit Product.

  1. Go to customizable options tab and add any custom options with drop down option type.
  2. Set zero(0) in the title field and click save the product.
  3. Product will save successfully and store zero value as a title of the drop down option.

Fixed Issues (if relevant)

  1. Can't save Customizable options #6305: Can't save Customizable options

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 19, 2018

CLA assistant check
All committers have signed the CLA.

@sidolov
Copy link
Contributor

sidolov commented May 22, 2018

Hi @Madhumalak , during QA activities we found that some scenarios are broken. Please, take a look at it.

Steps to reproduce:

  • Create New / Edit Product.
  • Go to customizable options tab and add any custom options with drop down option type.
  • Set zero(0) in the title field and click save the product
  • Save product.
  • Create order, invoice and shipment with this product.
  • Click Print for invoice and shipment.

Expected result:
Zero title field is displayed in pdf file(It is correct for Credit Memos).

Actual result:
Zero title field isn't be displayed in pdf file.

@Madhumalak
Copy link
Contributor Author

Hi @sidolov ,

I have fixed the issues that you have said and committed my code, Please check.

Steps to reproduce:

Create New / Edit Product.
Go to customizable options tab and add any custom options with drop down option type.
Set zero(0) in the title field and click save the product
Save product.
Create order, invoice and shipment with this product.
Click Print for invoice and shipment.

Now the result will be,

Zero title field is displayed in pdf file

@magento-engcom-team
Copy link
Contributor

Hi @Madhumalak. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants