Quote string for special characters. Fixes #3214

[reillo]

The path might contain regular expression character (i.e () which might cause UnexpectedValueException "Could not parse theme static file". Refer to #3214

Description

Fix issue of UnexpectedValueException "Could not parse theme static file" when 'bin/magento setup:static-content:deploy -f' is executed. This will also cause of missing static files.

Fixed Issues (if relevant)

1. Deploying Static Files. Could not parse theme static file #3214: Deploying Static Files. Could not parse theme static file

Manual testing scenarios

1. Put the Magento Application instance into the folder: C:/Program Files (x86)
2. Run bin/magento setup:static-content:deploy -f

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[miguelbalparda]

Windows is not supported as an operating system per DevDocs. Do you foresee any other cases where this might be relevant?

[reillo]

@miguelbalparda But it does work in Windows. That patch is not for windows only, it applies to all OS system. See the commit.

[reillo]

@magento-cicd2 CLA signed.

[oliverklee]

You'll also need to provide the second parameter to preg_quote to make sure the chose delimiter # gets escaped, too (so that the escape is always 100% correct).

[reillo]

Yep, right. Thanks @oliverklee

[miguelbalparda]

Your description only mentioned Windows, that's why I'm asking. I'm processing a similar PR and the same might apply.
To avoid any misunderstandings, while Magento 2 might work in Windows, it's not officially supported and that's why we usually reject PRs containing fixes for unsupported systems.
I'll check this internally and get back to you. Thanks!

[reillo]

@miguelbalparda Thanks, miguel. I'll be more specific next time. I'll update the description.

[orlangur]

@reillo,

But it does work in Windows

Actually, not fully, there are some known issues. It was already discussed in some older issues that for good it would be nice to have a proper OS check similar to the PHP version one. Before such check is implemented Windows-only issues and pull requests can be simply closed with an explanation.

So, before any fix can be actually merged there should be a corresponding VALID bug scenario first.

[miguelbalparda]

To make things clear, @oliverklee is an independent developer who asked for changes in this PR.

[oliverklee]

@miguelbalparda That's correct. :-)

As I'm quite new to the Magento project: Is it okay/helpful if I approve PRs that look okay to me, or should this task be limited to dedicated reviewers, core developers or something like this?

[miguelbalparda]

I actually asked the same question today in the maintainers channel :)
Basically, feel free to ask for changes where you see fit and keep in mind the final decision is made by maintainers. Thanks!

[miguelbalparda]

I'll close this for now, will revisit in the future if anything changes. Thanks @reillo!

[kanduvisla]

Why isn't this fix applied? I'm trying to deploy from a Jenkins server (which runs on Linux), from with a Docker container (that is exactly the proper setup for Magento 2) and I'm also getting this error.

If I understand the issue correctly the issue is that I have parenthesis in my path /var/lib/jenkins/workspace/prik-en-tik/Job Name (acceptance)/vendor/magento/theme-frontend-blank/web/css/_styles.less. A simple preg_quote() fixes this. Heck, you should always preg_quote() variable input inside a regex!

I'm running into this issue in Magento 2.1.12 by the way. I vote to re-open this issue.