-
Notifications
You must be signed in to change notification settings - Fork 9.4k
#12446: Add GetUtilityPageIdentifiers for Manage Custom Pages to be excluded … #12649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vkublytskyi I should add
|
@osrecio you may ignore Codacy failure if Magento static tests are green. Codacy is a recommendation, not a requirement. |
Some update @vkublytskyi ? Can I help you with something in this PR ? |
/** | ||
* Utility Cms Pages | ||
* | ||
* @api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to mark class as an @api
only interface is and API. Class as implementation is module internal details.
@osrecio I think we should remove |
@vkublytskyi Deleted |
…m Pages to be excluded … #12649
Added Interface and class to get collection of pages identifiers to be excluded from sitemap
Description
Get default pages from config to be excluded in Sitemap.
Fixed Issues (if relevant)
Manual testing scenarios
{domain}/home
{domain}/no-route
no longer exists for sitemapContribution checklist