Skip to content

#12446: Add GetUtilityPageIdentifiers for Manage Custom Pages to be excluded … #12649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Dec 12, 2017

Added Interface and class to get collection of pages identifiers to be excluded from sitemap

Description

Get default pages from config to be excluded in Sitemap.

Fixed Issues (if relevant)

  1. Remove /home from the sitemap.xml #12446: Remove /home from the sitemap.xml

Manual testing scenarios

  1. Create Sitemap
  2. the pages like {domain}/home {domain}/no-route no longer exists for sitemap

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vkublytskyi vkublytskyi self-assigned this Dec 12, 2017
@magento-engcom-team magento-engcom-team added Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 12, 2017
@osrecio
Copy link
Member Author

osrecio commented Dec 18, 2017

@vkublytskyi I should add @SuppressWarnings(PHPMD.LongVariable) below PhpDocBlock? Or I can omit it?

/**
 * Sitemap cms page collection model
 *
 * @api
 * @since 100.0.2
 * @SuppressWarnings(PHPMD.LongVariable)
 */

@vkublytskyi
Copy link

@osrecio you may ignore Codacy failure if Magento static tests are green. Codacy is a recommendation, not a requirement.

@osrecio
Copy link
Member Author

osrecio commented Jan 3, 2018

Some update @vkublytskyi ? Can I help you with something in this PR ?

/**
* Utility Cms Pages
*
* @api

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to mark class as an @api only interface is and API. Class as implementation is module internal details.

@vkublytskyi
Copy link

@osrecio I think we should remove @api annotation from a class as its interface already declared as module service contract and we can merge this PR.

@osrecio
Copy link
Member Author

osrecio commented Jan 4, 2018

@vkublytskyi Deleted @apiannotation :)

magento-team pushed a commit that referenced this pull request Jan 8, 2018
@magento-team magento-team merged commit 6ea1c43 into magento:2.2-develop Jan 8, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 8, 2018
@osrecio osrecio deleted the PR12446_2.2 branch February 6, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: complex Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants