Fix #8820 #8171 [backport 2.2] check typeId on product save #11645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlangur
added
Release Line: 2.2
2.2.x
Reproduced on 2.1.x
gomencal
changed the title
magento-engcom-team
added
bugfix
Component: Framework/Webapi
orlangur
requested changes
Nov 27, 2017
| @@ -326,6 +326,10 @@ private function cacheProduct($cacheKey, \Magento\Catalog\Api\Data\ProductInterf | |||
| */ | |||
| protected function initializeProductData(array $productData, $createNew) | |||
| { | |||
| if (empty($productData['type_id'])) { | |||
| $productData['type_id'] = \Magento\Catalog\Model\Product\Type::DEFAULT_TYPE; | |||
There was a problem hiding this comment.
Hi @gomencal,
So, we don't have any kind of schema validation for WebAPI, right? Like a way to forbid empty type_id.
Where exactly error occurs in case of empty type_id? Maybe it's better to put such assignment there instead of repository?
|
Closing due to inactivity. @gomencal, feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… #8820 #8171
When saving a product, check typeId control. If it's value isn't one of available, set the default one before saving.
Description
Set the default product type before saving it on repository, for prevent error on create stockitem and the undesired attributes deleting on \Magento\Catalog\Model\Product\Type\AbstractType::_removeNotApplicableAttributes()
Fixed Issues
Manual testing scenarios
Same testing described at issues #8820 and #8171. Save product via API.
Contribution checklist