Skip to content

Minicart height calculated incorrectly when child items contain margins #24441

Closed
@gwharton

Description

@gwharton

Preconditions (*)

  1. magento 2.3-develop

Steps to reproduce (*)

  1. Deploy 2.3-develop
  2. Create Test product and add to cart
  3. View minicart
  4. Open browser development tools
  5. Locate the line
    <li class="item product product-item" data-role="product-item">
  6. In the style explorer locate the css item
    .minicart-items .product-item
  7. Add the style
    padding-bottom: 100px !important;
  8. Close and reopen minicart to force reevaluation of height
  9. Notice that the minicart height is correctly calculated and there is a padding of 100px in the minicart.
    image
  10. Remove the style
    padding-bottom: 100px !important;
  11. Add the style
    margin-bottom: 100px !important;
  12. Close and reopen minicart to force reevaluation of height

Expected result (*)

  1. minicart height is correctly calculated.

Actual result (*)

  1. minicart height is not correctly calculated.
  2. Scroll bar appears in minicart
    image

When padding is used in the product-item list item the minicart calculated height correctly, but does not when margins are used.

Metadata

Metadata

Labels

Area: Design/FrontendComponent: CheckoutFixed in 2.3.xThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.3.xThe issue has been reproduced on latest 2.3 release

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions