Show issue when turn on Developer Mode - CE 2.3.0

[tuongnv-ub]

Preconditions (*)

1. Magento Version: CE 2.3.0
2. PHP Version 7.1.22
3. XamPP Server Localhost
4. Window 10
5. Developer Mode
6. Show error mode

Steps to reproduce (*)

1. Setup Magento Core CE 2.3.0
2. See Front-end

Expected result (*)

1. Show front-end without any issue.

Actual result (*)

1. Show error issue https://www.dropbox.com/s/tm0h1w58nil7j83/2018-11-30_10-23-09.png?dl=0

[magento-engcom-team]

Hi @tuongnv-ub. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@tuongnv-ub do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[phuongnd]

issue confirmed. We get the same issue.

[magento-engcom-team]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[orlangur]

@tuongnv-ub,

XamPP Server Localhost
Windows 10

This is not a valid environment, please check https://devdocs.magento.com/guides/v2.3/install-gde/system-requirements-tech.html

[00110000]

@orlangur But a LOT of people do their development work on windows.

This change is not deliberate; it's an error introduced by Magento and their Vagrant-only development ritual.

magento\framework\View\Element\Template\File\Validator.php

    /**
     * Checks whether path related to the directory
     *
     * @param string $path
     * @param string|array $directories
     * @return bool
     */
    protected function isPathInDirectories($path, $directories)
    {
        if (!is_array($directories)) {
            $directories = (array)$directories;
        }
        $realPath = $this->fileDriver->getRealPath($path);
        foreach ($directories as $directory) {
            if (0 === strpos($realPath, $directory)) {
                return true;
            }
        }
        return false;
    }

$realPath was added in 2.3.0 and does not return the expected slashes.

$realPath = 'C:\Server\Apache24\htdocs\magento-2.3\vendor\magento\module-theme\view\frontend\templates\page\js\require_js.phtml'
$directory = 'C:/Server/Apache24/htdocs/magento-2.3/vendor/magento/module-theme'

strpos cannot return 0 on Windows.

[orlangur]

@00110000,

a LOT of people do their development work on windows

It means nothing but they do their development wrong and at their own risk. There are a lot of options nowadays, like Docker, Vagrant or other virtualization technics available for Windows.

Windows is not supported, was never supported and always led to some bugs. Patches for Windows compatibility are not acceptable in this repo.

The only thing Magento lacks here is proper environment check, similar to an unsupported PHP version check. Hope it will change soon.

@tuongnv-ub @00110000 -> https://www.howtogeek.com/249966/how-to-install-and-use-the-linux-bash-shell-on-windows-10/

@00110000 i'm know a guy, who works with WSL a long time, and have no issue with it. so this may be a good solution

[tuongnv-ub]

@engcom-backlog-nazar , @00110000 . Thanks for sharing. I'm Setup and working with WSL as well.

[orlangur]

@engcom-backlog-nazar would be great to have such setup described somewhere in DevDocs for Windows guys. It would be much more friendly than just pointing to system requirements: https://github.com/magento/magento2/blob/2.3-develop/app/bootstrap.php#L17