sales_order_item_save_commit_after and sales_order_save_commit_after events will never fire for guest checkout

[swnsma]

Preconditions

1.Magento version: 2.2.6
2. PHP 7.1.x
3. Completely clean install with no demo data

Steps to reproduce

1. Create new observers for events sales_order_item_save_commit_after and sales_order_save_commit_after.
2. Complete checkout as guest user.

Expected result

1. Events have fired.
2. Observers have processed events.

Actual result

1. Events have not fired.

Additional information

For guest checkout there are two additional transactions open in 'GuestPaymentInformationManagement'.

These transactions lead to fact that transaction level will never be set less than '2' and after commit callback will not be processed.

Possible fix

Transactions were opened to solve issue with QTY concurrency while order is placing (concurrent order placement could lead to negative stock value).
So, possible, issue could be fixed by moving \Magento\CatalogInventory\Observer\SubtractQuoteInventoryObserver to Sales Order Save transaction.

[magento-engcom-team]

Hi @swnsma. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@swnsma do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[sidolov]

Hi @swnsma. Thank you for your report.
The issue has been fixed in #19040 by @swnsma in 2.3-develop branch
Related commit(s):

• 5dc7add05b66271f4ad8c8be85c20d4beb173306
• e19d70e3fd43184eeeb009129bf0a564fae002ea

The fix will be available with the upcoming 2.3.1 release.

[magento-engcom-team]

Hi @swnsma. Thank you for your report.
The issue has been fixed in #19036 by @swnsma in 2.2-develop branch
Related commit(s):

• 429815bee09f999ef3e38b93a5c097363fe2cbbd

The fix will be available with the upcoming 2.2.8 release.

[navarr]

@sidolov This issue is not fixed in 2.3.1. The issue's contents describe the same cause of #19040 but the underlying problem still exists.

[navarr]

@svitja: You committed 6fa1f22 which is what resulted in this change of functionality.

Is there any reason you performed this change only for guest checkout?

[m2-assistant]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.