Fix #11175 - i18n:collect-phrases -m can't find many important magento phrases - made patterns case-sensitive because translations does not work with uppercase bindings/tags/function names

Author: maksymz

setup/src/Magento/Setup/Module/I18n/Parser/Adapter/Html.php

@@ -22,19 +22,19 @@ class Html extends AbstractAdapter
      * @deprecated Not used anymore because of newly introduced constant
      * @see self::HTML_REGEX_LIST
      */
-    const HTML_FILTER = "/i18n:\s?'(?<value>[^'\\\\]*(?:\\\\.[^'\\\\]*)*)'/i";
+    const HTML_FILTER = "/i18n:\s?'(?<value>[^'\\\\]*(?:\\\\.[^'\\\\]*)*)'/";
 
     private const HTML_REGEX_LIST = [
         // <span><!-- ko i18n: 'Next'--><!-- /ko --></span>
         // <th class="col col-method" data-bind="i18n: 'Select Method'"></th>
-        "/i18n:\s?'(?<value>[^'\\\\]*(?:\\\\.[^'\\\\]*)*)'/i",
+        "/i18n:\s?'(?<value>[^'\\\\]*(?:\\\\.[^'\\\\]*)*)'/",
         // <translate args="'System Messages'"/>
         // <span translate="'Examples'"></span>
-        "/translate( args|)=\"'(?<value>[^\"\\\\]*(?:\\\\.[^\"\\\\]*)*)'\"/i",
+        "/translate( args|)=\"'(?<value>[^\"\\\\]*(?:\\\\.[^\"\\\\]*)*)'\"/",
         // <a data-bind="attr: { title: $t('This is \' test \' data'), href: '#'} "></a>
         // <input type="text" data-bind="attr: { placeholder: $t('Placeholder'), title: $t('Title') }" />
         // Double quotes are not handled correctly in the `attr` binding. Move phrase to the UI component property if needed
-        '/\\$t\(\s*([\'"])(?<value>.*?[^\\\])\1.*?[),]/i'
+        '/\\$t\(\s*([\'"])(?<value>.*?[^\\\])\1.*?[),]/'
     ];
 
     /**

setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/HtmlTest.php

@@ -49,6 +49,7 @@ public function testParse()
                 'line' => '',
                 'quote' => '',
             ],
+            // `I18N` is not parsed - bindings are case-sensitive
             [
                 'phrase' => 'This is test data at right side of attr',
                 'file' => $this->testFile,
@@ -97,12 +98,15 @@ public function testParse()
                 'line' => '',
                 'quote' => '',
             ],
+            // `<TRANSLATE>` tag is not parsed - only lowercase tags are accepted
             [
                 'phrase' => 'This is test content in translate attribute',
                 'file' => $this->testFile,
                 'line' => '',
                 'quote' => '',
             ],
+            // `TRANSLATE` attribute is not parsed - only lowercase attribute names are accepted
+            // `$T()` is not parsed - function names in JS are case-sensitive
             [
                 // en_US.csv: "This is ' test ' data for attribute translation with single quotes","This is ' test ' data for attribute translation with single quotes"
                 'phrase' => 'This is \\\' test \\\' data for attribute translation with single quotes',

setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/_files/email.html

@@ -21,6 +21,7 @@
         }}
     </span>
     <label data-bind="i18n: 'This is test data', attr: {for: 'more-test-data-'}"></label>
+    <label data-bind="I18N: 'This is test data with uppercase binding', attr: {for: 'more-test-data-'}"></label>
     <label data-bind="attr: {for: 'more-test-data-' + $parent.getCode()}"><span data-bind="i18n: 'This is test data at right side of attr'"></span></label>
     <label data-bind="i18n: 'This is \' test \' data', attr: {for: 'more-test-data-' + $parent.getCode()}"></label>
     <label data-bind="i18n: 'This is \" test \" data', attr: {for: 'more-test-data-' + $parent.getCode()}"></label>
@@ -30,7 +31,10 @@
     <label data-bind="i18n: '\''"></label>
     <label data-bind="i18n: '\\\\ '"></label>
     <span><translate args="'This is test content in translate tag'" /></span>
+    <span><TRANSLATE args="'This is test content in the uppercase translate tag'" /></span>
     <span translate="'This is test content in translate attribute'"></span>
+    <span TRANSLATE="'This is test content in uppercase translate attribute'"></span>
+    <a data-bind="attr: { title: $T('This is test data for invalid attribute translation'), href: '#'} "></a>
     <a data-bind="attr: { title: $t('This is \' test \' data for attribute translation with single quotes'), href: '#'} "></a>
     <a data-bind="attr: { title: $t('This is test data for attribute translation with a quote after\'\''), href: '#'} "></a>
     <a data-bind="attr: { title: $t('This is test data for attribute translation with a quote after\' \' '), href: '#'} "></a>